feat(typescript): upgrade to typescript 2.7.2 - #431
Conversation
| }, | ||
| }, | ||
| contents: [{ language: 'typescript', value: 'import Foo' }, '**alias**'], | ||
| contents: [{ language: 'typescript', value: 'class Foo\nimport Foo' }, '**alias**'], |
There was a problem hiding this comment.
Looks like hovers now give you more symbol info than just the import statement!
Codecov Report
@@ Coverage Diff @@
## master #431 +/- ##
=========================================
- Coverage 83.26% 83.16% -0.1%
=========================================
Files 15 15
Lines 2038 2038
Branches 482 415 -67
=========================================
- Hits 1697 1695 -2
- Misses 339 341 +2
Partials 2 2
Continue to review full report at Codecov.
|
|
Anything I can/should do about the drop in code coverage? |
|
Hmm, seems like https://codecov.io/gh/sourcegraph/javascript-typescript-langserver/pull/431/changes#L95 |
|
Still part of the interface: https://github.com/Microsoft/TypeScript/blob/v2.7.2/src/services/types.ts#L163 Looks like there was a recent change to prioritize the use of I'll remove that function from the language service host and see what happens! |
|
In that case just leave it in and not worry about the coverage |
|
Ok, sounds good! |
2 participants
/cc @damieng